sanitize CK_DESCRIPTION in tool descriptions; validate document_id; stop echoing backend error bodies#6
Closed
lwsinclair wants to merge 1 commit into
Closed
Conversation
…top echoing backend error bodies
thuong-nguyen-ea
approved these changes
Apr 20, 2026
thuong-nguyen-ea
left a comment
thuong-nguyen-ea
left a comment
There was a problem hiding this comment.
LGTM — CK_DESCRIPTION + document_id + error-body
mseep-ai
deleted the
fix/sanitize-ck-description-and-validate-document-id
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CK_DESCRIPTION was being substituted into tool-description strings directly, so a CK owner could inject arbitrary prompt-injection content into the LLM instructions seen by every consumer of the generated server. Now wrapped in a clearly-marked untrusted-context block and stripped of control chars.
document_id from resource URIs was passed into URL paths unchecked — validated with a hex/dash regex.
APIClient.get / .post no longer echo the full backend error body back to the client on non-2xx; they raise a plain McpError with just the status code.
Fixes here cascade to future template-generated CK servers. Existing generated repos still need the same fix applied directly.