Skip to content

[compass] Fix: the "execution jobs" quick check fails on a slow machine at its first job ("exit code or streams missing") #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skulitom merged 2 commits into from
Oct 8, 2026
Merged

[compass] Fix: the "execution jobs" quick check fails on a slow machine at its first job ("exit code or streams missing") #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c85acad
Quick checks: read a command job until it finishes instead of judging…
skulitom Oct 7, 2026
04b2d64
Quick checks: name the job reader ReadUntilFinished, give the PID ste…
skulitom Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/Anode/Cli/DevelopmentChecks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,18 @@ ProcessStartInfo Worker(string code)
Convert.ToBase64String(Encoding.Unicode.GetBytes("$null = [Console]::In.ReadLine(); " + code)) }) info.ArgumentList.Add(arg);
return info;
}
// Windows PowerShell can take longer than one wait (10 s at most) to start on a cold machine, so read a job
// that should finish until it does, for up to 30 s, before judging its result.
static async Task<JsonObject> ReadUntilFinished(ExecutionJobs jobs, JsonObject reply)
{
for (var clock = Stopwatch.StartNew(); reply.Bool("finished") != true && clock.ElapsedMilliseconds < 30000; )
reply = await jobs.ReadAsync(new JsonObject { ["jobId"] = reply.Str("jobId"),
["waitMs"] = (int)Math.Clamp(30000 - clock.ElapsedMilliseconds, 1, 10000) }, reply.Str("agentId")!);
return reply;
}
using (var jobs = new ExecutionJobs(() => Worker("[Console]::Out.Write('hello'); [Console]::Error.Write('problem'); exit 7")))
{
var done = await jobs.StartAsync(new JsonObject { ["path"] = "unused-test-command", ["waitMs"] = 10000 }, "test-agent");
var done = await ReadUntilFinished(jobs, await jobs.StartAsync(new JsonObject { ["path"] = "unused-test-command", ["waitMs"] = 10000 }, "test-agent"));
Require(done.Bool("finished") == true && done.Int("exitCode") == 7 && done.Str("stdout") == "hello" && done.Str("stderr") == "problem", "exit code or streams missing: " + done);
var listed = await jobs.ReadAsync(new JsonObject { ["action"] = "list" }, "test-agent");
Require(listed["jobs"] is JsonArray { Count: 1 }, "interrupted-call job recovery unavailable");
Expand All @@ -163,7 +172,7 @@ ProcessStartInfo Worker(string code)
return info;
}))
{
var done = await jobs.StartAsync(new JsonObject { ["path"] = "unused-test-command", ["waitMs"] = 10000 }, "test-agent");
var done = await ReadUntilFinished(jobs, await jobs.StartAsync(new JsonObject { ["path"] = "unused-test-command", ["waitMs"] = 10000 }, "test-agent"));
Require(done.Bool("finished") == true && done.Int("exitCode") == 0
&& done.Str("stdout") == "caf\u00e9 \u6771\u4eac \U0001F680" && done.Str("stderr") == "caf\u00e9 \u6771\u4eac \U0001F680",
"UTF-8 output depends on the host console encoding: " + done);
Expand All @@ -186,7 +195,7 @@ ProcessStartInfo Worker(string code)
Require(rejected, "the cancelled client call still waited for its command");
var listed = await jobs.ReadAsync(new JsonObject { ["action"] = "list" }, "test-agent");
Require(listed["jobs"] is JsonArray { Count: 1 }, "interrupted start was not recoverable or created more than one job");
var recovered = await jobs.ReadAsync(new JsonObject { ["jobId"] = listed["jobs"]![0]!["jobId"]!.DeepClone(), ["waitMs"] = 10000 }, "test-agent");
var recovered = await ReadUntilFinished(jobs, await jobs.ReadAsync(new JsonObject { ["jobId"] = listed["jobs"]![0]!["jobId"]!.DeepClone(), ["waitMs"] = 10000 }, "test-agent"));
Require(recovered.Bool("finished") == true && recovered.Str("state") == "completed" && recovered.Str("stdout") == "survived",
"client cancellation killed an already started command");
}
Expand All @@ -198,7 +207,7 @@ ProcessStartInfo Worker(string code)
var output = started;
for (var clock = Stopwatch.StartNew(); output.Str("stdout") is not { } line || !line.Contains('\n'); )
{
Require(clock.ElapsedMilliseconds < 15000 && output.Bool("finished") != true, "descendant did not start: " + output.Str("summary"));
Require(clock.ElapsedMilliseconds < 30000 && output.Bool("finished") != true, "descendant did not start: " + output.Str("summary"));
output = await jobs.ReadAsync(new JsonObject { ["jobId"] = started.Str("jobId"), ["waitMs"] = 200 }, "test-agent");
}
Require(int.TryParse(output.Str("stdout")!.Trim(), out int descendant), "descendant did not start: " + output.Str("summary"));
Expand Down
Loading