ci(shacl): add shape validation for sample data#59
Conversation
|
@vicding-mi do you have time to check the PR ? see also #58 for context. |
There was a problem hiding this comment.
not sure whether the submodule can trigger the action pipeline. Please kindly elaborate. The push or pr would update the pointer in the parent repository, but files in sub-folder might not be enough to trigger the pipeline.
There was a problem hiding this comment.
Makes sense. What about filtering on the gitlink path itself, data-model, instead of the sub-folder? A push/PR that bumps the pointer changes exactly that path, so the workflow fires (tested here https://github.com/orgs/community/discussions/66060).
That means validation runs whenever we bump the submodule here, which is the moment we actually want to re-check the sample data against the new shapes. It won't run if the shapes change upstream without a pointer bump.
There was a problem hiding this comment.
This file does not need the api spec (yaml) to run. It checks sample data against shacl.ttl (which is included as git submodule). Is shacl.ttl derivation of the openapi specs? Am I missing some context?
There was a problem hiding this comment.
OpenAPI check and SHACL check are two separate jobs in this workflow. I added the SHACL step leaving the preexisting OpenAPI job untouched
|
@rduyme I checked the code base with @arcangelo7 . Can you please take over and proceed? I have read-only access, cannot approve the merge. |
3 participants
No description provided.