Skip to content

feat: Add VS Code extension#41

Open
hongjr03 wants to merge 6 commits into
skanehira:mainfrom
hongjr03:feat/vscode-extension
Open

feat: Add VS Code extension#41
hongjr03 wants to merge 6 commits into
skanehira:mainfrom
hongjr03:feat/vscode-extension

Conversation

@hongjr03

Copy link
Copy Markdown

Summary

This PR adds a VS Code extension for version-lsp.

  • Creates editors/code directory with extension structure.
  • Implements LSP client to launch version-lsp binary.
  • Adds configuration for server path.
  • Adds README and initial configuration.

Note: users need to have version-lsp installed and available in PATH or configured via settings.

@hongjr03
hongjr03 marked this pull request as draft January 18, 2026 06:56
@hongjr03
hongjr03 marked this pull request as ready for review January 18, 2026 07:07

@skanehira skanehira left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
I've made some comments below.

Additionally, please address the following items:

Since editors/code has been added, update CLAUDE.md
Add CI to verify that editors/code/src/extension.ts can be built

Comment thread editors/code/package.json
"lint": "eslint src --ext ts",
"package": "vsce package"
},
"devDependencies": {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To improve the development experience, could you add oxlint and oxfmt and apply them?

Comment thread editors/code/package.json
"@types/vscode": "^1.75",
"@typescript-eslint/eslint-plugin": "^8.53.0",
"@typescript-eslint/parser": "^8.53.0",
"eslint": "^9.39.2",

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to remove eslint if I install oxlint instead.

Comment thread editors/code/README.md
You need to have `version-lsp` installed.

```bash
cargo install version-lsp

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/main.rs
#[command(version, about = "Language Server for package version management")]
struct Cli {
#[arg(long)]
stdio: bool,

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this argument is necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants