Conversation
Collaborator
Author
|
@lv-zheng Could you please review this PR at https://github.com/sjtug/nginx-simple-watcher/pull/5/files? |
lv-zheng
approved these changes
Sep 27, 2016
lv-zheng
left a comment
lv-zheng
left a comment
Contributor
There was a problem hiding this comment.
I have not spared my time to test this code. The code seems nice and it should work. How about forcing the status code to be 2xx or 3xx?
Collaborator
Author
|
@lv-zheng I'd prefer keeping them. Error response deserves more attention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #3