Enable RTL layouts - #380
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
I made some changes like the notification/avatar/language menu layering, notification panel RTL layout, entity/detail action spacing, floating visualization controls, media redactor/viewer RTL behavior, SplitView resizing, and related icon spacing issues.
Approved.
2 participants
Makes the admin UI render correctly right-to-left. Split out of #377, which now carries string translations only.
Direction plumbing
current_language/current_directioncontext processor derived from the active locale viababel.Locale.character_order<html lang dir>on all four layouts (main, login, security, setup wizard)localeoption so its own components follow suitLogical properties
location="right"->location="end"on all 11 first-party navigation drawers plus the map drawerml-*/mr-*->ms-*/me-*in the components that carried directional spacingleft-auto/right-0split-view classes replaced withinset-inline-start-0/inset-inline-end-0utilitiesdir="auto"on notification title/message (user content can be either direction),dir="ltr"on the timestampprependslot with a tightened SVG viewBox, so it sits next to the menu icon in both directionsTests
tests/test_rtl.py: direction rendering for ar/en plus guards against reintroducing hardcodedlocation="right"and physical spacing in the swept files.