Fix Wikipedia first-party regex and missing cookies on newline-joined#136
Merged
Conversation
Set-Cookie The auto-derived first-party regex for Wikipedia pages contained a || where a single | was meant. The empty alternative between the two pipes matched every string, so any third-party request (analytics, ads, CDNs) on a Wikipedia page was wrongly classified as first-party and the thirdParty bucket stayed empty. One-character fix in the regex, plus a small regression test built from an inline HAR. While in the area: getThirdPartyCookieNames was recently taught to stop the Domain= capture at \n because some HARs concatenate multiple Set-Cookie response headers into one value joined by newlines. Its sister getCookieNames still split only on the first = and therefore silently dropped every cookie after the first in such a joined block, under-reporting page.cookies and page.cookieNames. Apply the same newline split there so both functions agree on the format. Co-authored-by: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set-Cookie
The auto-derived first-party regex for Wikipedia pages contained a ||
where a single | was meant. The empty alternative between the two pipes
matched every string, so any third-party request (analytics, ads, CDNs)
on a Wikipedia page was wrongly classified as first-party and the
thirdParty bucket stayed empty. One-character fix in the regex, plus a
small regression test built from an inline HAR.
While in the area: getThirdPartyCookieNames was recently taught to stop
the Domain= capture at \n because some HARs concatenate multiple
Set-Cookie response headers into one value joined by newlines. Its
sister getCookieNames still split only on the first = and therefore
silently dropped every cookie after the first in such a joined block,
under-reporting page.cookies and page.cookieNames. Apply the same
newline split there so both functions agree on the format.
Co-authored-by: Claude noreply@anthropic.com