BUGFIX: Pass the workspace to the UpdateWorkspaceInfo feedback - #104
Merged
Merged
Conversation
Neos.Neos.Ui takes the workspace as a constructor argument now and dropped setWorkspace, so both translation changes died with an ArgumentCountError before they could send their feedback. This also makes phpstan pass again.
mficzel
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on
2.0is currently red, independently of any open PR.composer testoncd0946b(v2.7.1, the current2.0head) fails with four phpstan errors inClasses/Ui/Changes/AddMissingTranslations.phpandClasses/Ui/Changes/UpdateOutdatedTranslations.php. The last run on2.0was green on 02.07.2026; nothing has been pushed since, so no run has surfaced it.Neos\Neos\Ui\Domain\Model\Feedback\Operations\UpdateWorkspaceInfonow takes the workspace as a required constructor argument and no longer hassetWorkspace(). Both call sites still use the old two-step API, so this is not only a static-analysis complaint —new UpdateWorkspaceInfo()raises anArgumentCountError, i.e. "Add missing translations" and "Update outdated translations" abort before they can send their feedback.Note that
composer require neos/neos ^8.3in the workflow resolves toneos/neos 8.4.7/neos/neos-ui 8.4.4today, so the "Neos 8.3" matrix label is misleading — the job is really testing against 8.4.With this change
composer testis green again (style, phpstan level 8, 56 unit tests).