Repository navigation
Assert the build-layout floor and pin go-release to d648d89 - #48
Merged
Merged
Conversation
TestBuildLayout now counts the files it inspected in build/ (those at the root and in each OS folder) and fails below BUILD_LAYOUT_MIN. make build passes 2, and make cross and make dist pass one per target plus targets.txt and checksums.txt, so a check that reads an empty or wrong directory fails instead of passing. A new test pins the count.
release.yml calls simtabi/.github's go-release.yml at its latest commit, d648d89 (simtabi/.github#30). The commits since the old pin add optional inputs only; every input this caller passes is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two sweeps in one PR, one commit each, plus the changelog.
build/<os>/only). Measured first:build/already holds one folder per OS with{binary}_{os}_{arch}names,checksums.txtover{os}/{file}, the host build inbuild/<host-os>/, GoReleaser'sdist:in the ignored.cache/goreleaser, and a guard with red cases fordist/,darwin/and per-target folders. The one gap was that the guard did not assert how many entries it inspected. It now counts the files at the root ofbuild/and in each OS folder and fails belowBUILD_LAYOUT_MIN: 2 aftermake build, one per target plustargets.txtandchecksums.txtaftermake cross/make dist.release.ymlcallssimtabi/.github/.github/workflows/go-release.yml@d648d8998f95a351001979f9c4527badca588bf1 # simtabi/.github#30, the latest commit. The commits since the old pin add optional inputs only (node-versionand earlierenvironment/runs-on/post-release); nothing this caller passes changed..github/dependabot.ymlalready has a weekly, groupedgithub-actionsentry, and agent-kit'sdependabot.py checkreports no drift. It will not advance this pin by itself: simtabi/.github has no tags, and Dependabot's GitHub Actions updater only moves a commit-SHA pin to a tagged release.Verification
go -C src vet ./...: clean.go -C src test -count=1 ./...: everything passes exceptinternal/netcheck's TestOnlineWhenProbeReturns204, which the local sandbox's network refuses; CI runs it.make build-local(floor 2) andmake cross(19 binaries, floor 21, 23 entries inspected): greenmake check-build BUILD_LAYOUT_MIN=999fails with "inspected N entries in build/, expected at least 999". Red, stray: abuild/dist/folder fails the check. Both reverted, andmake check-buildis green again.release.yml: clean