Repository navigation
Point the install scripts' source fallback at the src/ module - #45
Merged
Merged
Conversation
The fallback still named github.com/simtabi/vigil/cmd/vigil, the path from before the module moved into src/, so it resolved to the frozen 0.7.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/scripts/install.shandinstall.ps1fall back togo installwhen the release download fails. They still namedgithub.com/simtabi/vigil/cmd/vigil@latest, the path from before the module moved intosrc/, which resolves to the frozen 0.7.0.github.com/simtabi/vigil/src/cmd/vigil@latest. Nosrc/tag exists yet, so this builds the default branch.[Unreleased]gains a Fixed entry.Testing
bash -n src/scripts/install.shgo -C src test ./...: all packages pass exceptinternal/netcheck, which fails locally only because the sandbox blockshttptestport binding. CI runs it.make buildwritesbuild/macos/vigil, andTestBuildLayoutpasses.