Repository navigation
Generate the redaction test values with crypto/rand - #41
Merged
Merged
Conversation
TestRedactLiterals wrote 'supersecretvalue' down, and the token-shape cases were a prefix plus a run of one repeated letter, which GitGuardian still matched and reported. Every value is now drawn from crypto/rand in the alphabet its pattern expects, so the cases also cover more than one fixed string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/secret/redact_test.gowrote downsupersecretvalue. Its token-shape cases were a prefix plus one repeated letter, which GitGuardian still matched.crypto/randin the alphabet its pattern expects.Verification
go test -count=5 ./internal/secret/andgo vetare clean.