Repository navigation
Assemble token-shaped redactor test values at run time - #34
Merged
Merged
Conversation
The redactor test carried ghp_, glpat- and AKIA literals that secret scanners match by prefix. Build the same shapes with strings.Repeat so the test still proves each pattern is masked, with no literal in the source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/secret/redact_test.gocarriedghp_,glpat-andAKIAliterals that scanners match by prefix. They are now assembled at run time withstrings.Repeat, in the same shapes, so the test still proves each pattern is masked.No config change: no fixture or example-env paths, and the existing
.gitleaks.tomlis left as it is.Verified locally:
secret_scan.py check --ref HEADexits 0. Gates: go build, go vet, go test -race, golangci-lint (0 issues).