Skip to content

Bump vite to 8 and laravel-vite-plugin to 3 together - #36

Merged
imanimanyara merged 1 commit into
mainfrom
chore/vite-8-laravel-vite-plugin-3
Oct 2, 2026
Merged

imanimanyara merged 1 commit into
mainfrom
chore/vite-8-laravel-vite-plugin-3

Conversation

@imanimanyara

Copy link
Copy Markdown
Member

laravel-vite-plugin 2.x peers vite ^7 and 3.x peers vite ^8, so each half alone (#1, #13) fails npm ci in the node 22 · assets job with a peer conflict. This moves both in one change (vite ^8.3.2, laravel-vite-plugin ^3.2.0) and regenerates the lock. npm ci && npm run build passes locally with no config change.

Supersedes #1 and #13. #16 carried the same combined bump but was closed by Dependabot as up-to-date during a rebase without having been merged.

laravel-vite-plugin 2.x declares a peer of vite ^7 and 3.x a peer of vite ^8,
so bumping either one alone (Dependabot #1, #13) leaves npm ci with an
unresolvable peer conflict and the assets job fails. Moving both in one
change keeps the tree resolvable; vite build passes with unchanged config.
Copilot AI balanced review requested due to automatic review settings October 2, 2026 09:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The paired upgrade is compatible and builds are covered by CI; the lockfile identity rename is a non-blocking cleanup.

Review effort: Balanced
Findings: None

What changed in this PR

Updates Vite and Laravel’s Vite plugin together to maintain peer compatibility.

Changes:

  • Upgrades Vite to 8.3.2 and laravel-vite-plugin to 3.2.0.
  • Regenerates transitive dependencies for Vite’s Rolldown-based toolchain.
File Description
package.json Updates the paired frontend dependencies.
package-lock.json Locks the upgraded dependency graph.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@imanimanyara
imanimanyara merged commit 195f53f into main Oct 2, 2026
7 checks passed
@imanimanyara
imanimanyara deleted the chore/vite-8-laravel-vite-plugin-3 branch November 1, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants