Repository navigation
Bump vite to 8 and laravel-vite-plugin to 3 together - #36
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The paired upgrade is compatible and builds are covered by CI; the lockfile identity rename is a non-blocking cleanup.
Review effort: Balanced
Findings: None
What changed in this PR
Updates Vite and Laravel’s Vite plugin together to maintain peer compatibility.
Changes:
- Upgrades Vite to 8.3.2 and
laravel-vite-pluginto 3.2.0. - Regenerates transitive dependencies for Vite’s Rolldown-based toolchain.
| File | Description |
|---|---|
package.json |
Updates the paired frontend dependencies. |
package-lock.json |
Locks the upgraded dependency graph. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
laravel-vite-plugin 2.x peers
vite ^7and 3.x peersvite ^8, so each half alone (#1, #13) failsnpm ciin thenode 22 · assetsjob with a peer conflict. This moves both in one change (vite ^8.3.2, laravel-vite-plugin ^3.2.0) and regenerates the lock.npm ci && npm run buildpasses locally with no config change.Supersedes #1 and #13. #16 carried the same combined bump but was closed by Dependabot as up-to-date during a rebase without having been merged.