Repository navigation
Release on a version tag or on request - #4
Merged
Merged
Conversation
The org's Go release standard (2026-11-13) replaces the dispatch gated on confirm=release-go with two triggers: a pushed vX.Y.Z tag, and a dispatch naming an existing tag (-f tag=vX.Y.Z). The job resolves the tag from either, checks it is a version on GitHub, and checks out refs/tags/<tag>. cloudkit is a library with no binaries, so it keeps its own release job rather than calling simtabi/.github's shared go-release.yml, which runs GoReleaser. The alias tag, the CHANGELOG notes, the create-or-update of the release and the release environment are unchanged. The policy guard now asserts exactly those two triggers, version-only tag filters, a required tag input and a release built from the tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings cloudkit's release workflow onto the org's Go release standard of 2026-11-13: a release runs on a pushed version tag, or on request for a tag already pushed, and on nothing else. This replaces the dispatch gated on
-f confirm=release-go, which no release ever used (no version is tagged yet).This is the library exception. Every other Go repository's
release.ymlcallssimtabi/.github's sharedgo-release.yml, but that workflow runs GoReleaser, and cloudkit has no binaries. So cloudkit keeps its own job and only the triggers change.v[0-9]+.[0-9]+.[0-9]+andv[0-9]+.[0-9]+.[0-9]+-*tags, plusworkflow_dispatchwith a requiredtaginput. Concurrency is per tag and never cancelled.inputs.tag || github.ref_name. The first step refuses anything that is notvX.Y.Z[-pre]or not a tag on GitHub, and the checkout isrefs/tags/<tag>, so a dispatch can no longer build from a branch.src/vX.Y.Zalias (created if missing, refused if it points elsewhere), the CHANGELOG-section notes (which fail closed), create-or-update of the release, thereleaseenvironment, and the permissions.TestReleaseRunsOnlyOnAConfirmedDispatchis replaced byTestReleaseRunsOnAVersionTagOrOnRequest. It asserts exactlypush+workflow_dispatch, no branch or path filter, version-only tag filters, a requiredtaginput, the tag-check and tag-checkout lines, norelease-go, and still nothing that builds or publishes a binary (GoReleaser, the sharedgo-release.yml, artifacts, Docker, Homebrew, Scoop) outside comments.docs/release.mdnow describes the two ways and states the library exception. The workflow registration note is gone: it applied only to a dispatch-only workflow, and this one has a push trigger. The CHANGELOG[Unreleased]entry for the release workflow now describes the new triggers.Verification
make ci(gofmt check, vet,go test -race -count=1): green.make lint(golangci-lint v2.15.0): 0 issues. actionlint 1.7.12: clean on both workflows.go test -count=1, one defect at a time, and the file restored (confirmed withcmp). Each of these failed:branches: [main]on the push trigger; ascheduletrigger; a'*'tag filter;required: falseon the tag input; checkout ofmaininstead of the tag; agoreleaser-actionstep.