Repository navigation
Set up Node in the Go release, the latest unless pinned - #30
Merged
Merged
Conversation
A GoReleaser before-hook that builds a web UI needs Node. The new node-version input defaults to the latest release; browser-foreman passes 22 to match its CI.
imanimanyara
added a commit
to ichava/icon-sets-sync
that referenced
this pull request
Nov 13, 2026
release.yml calls simtabi/.github's go-release.yml at its latest commit, d648d89 (simtabi/.github#30). The new commit adds an optional node-version input; every input this caller passes is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node-versioninput ongo-release.yml, defaultlatest(owner, 2026-11-13: "default should always be the latest version"), used by a newSet up Nodestep (actions/setup-node@v7) before GoReleaser, so a before-hook that builds a web UI has Node. browser-foreman will pass22, matching its CI.Verification
python3 -m unittest discover -s go-release/tests: pass. The new test fails on a non-latest default and on a hard-coded version in the step (both planted, then restored).