Repository navigation
Name the shared workflow as signer in the verify command - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A caller's release is signed by this reusable workflow, not by the caller's own
release.yml. Sogh attestation verify <file> --repo OWNER/REPOfails withError: verifying with issuer "sigstore.dev", becauseghexpects a workflow in the caller's repository. Adding--signer-workflow simtabi/.github/.github/workflows/go-release.ymlmakes it pass. Measured 2026-11-13 against simtabi/authama v0.1.6: exit 0 with the flag, failure without.go-release/README.md, under Attestations: the verify command with the flag, and why it is needed..github/workflows/go-release.ymlandtemplates/go/release.yml: the same command in their header comments. These are comment-only changes.go-release/tests/test_go_release.py: a newVerifyCommandstest. Everygh attestation verifyin the three files must name the signer (a backslash-continued command is read as one line), and at least 3 must be found. Seen red both ways: with the flag removed from the template, and with no commands found.authama's own docs get the same fix in sangehq/authama#189.
Checks
python3 -m unittest discover -s go-release/tests: 12 tests, OK.