Repository navigation
Let Go release callers pick runner, environment and signing - #28
Merged
Merged
Conversation
Adds a runs-on input (default ubuntu-latest) for a darwin build that needs cgo on macOS, an environment input (default empty) for a release run under a GitHub environment, and an optional SIGNPATH_API_TOKEN secret exported to GoReleaser. Both attestation steps now skip on a private repository, where GitHub Free refuses attestations. Each is documented in go-release/README.md and pinned by a test.
imanimanyara
added a commit
to simtabi/vigil
that referenced
this pull request
Nov 13, 2026
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four additions to the shared Go release workflow, each optional, so every existing caller behaves exactly as before:
runs-oninput (defaultubuntu-latest), used as the job'sruns-on. simtabi/vigil builds darwin withCGO_ENABLED=1and has to release onmacos-latest.environmentinput (default empty), used asenvironment: ${{ inputs.environment }}. An empty name runs the job under no environment. wli-kit and go-template run their release underenvironment: release.SIGNPATH_API_TOKENsecret (on.workflow_call.secrets,required: false), exported into the GoReleaser step's env. wli-kit signs throughsrc/scripts/sign.shwith it. Callers pass it explicitly, never withsecrets: inherit.if: github.event.repository.private == false, because GitHub Free refuses attestations there.github.event.repositoryis the caller's repository, which is set on the push and workflow_dispatch events that start a release. The release itself still publishes.go-release/README.mdgains the two inputs in its table, plus Secrets and Attestations sections.Not verified by a real release run: that an empty
environmentvalue means "no environment" at run time. actionlint accepts it, and no caller has run this revision yet.Verification
python3 -m unittest discover -s go-release/tests -v: 11 tests pass, 4 of them new.actionlint1.7.12 is clean over the repository's workflows.runs-ondefault changed, jobruns-onhard-coded,runs-oninput removed;environmentline removed,environmentdefault set torelease; secret maderequired: true, secret dropped from the GoReleaser env; the private-repoif:removed from each attestation step. Each failed its test.