Repository navigation
Rewrite a drifting Dependabot config with render, not check - #16
Merged
Merged
Conversation
The reconciler detected drift and then fixed none of it. `check --write` creates the file, or appends an ecosystem the file is missing; it does not rewrite one that covers everything and is simply wrong -- which is what drift is. So every repository reached `changed_paths`, found nothing, and came back `skipped:write-made-no-change`. Measured 2026-11-02, dry run across simtabi: cli-kit-js, mesobia, netsapiens-api, repo-templates and sis-sdk all returned that status. Nothing had ever been proposed. `render --write` replaces everything outside the local block, which is what the reconciler is for; the same three repositories now report `would-open`. The reason the suite did not catch it is in the fake, not in the tests: `git clone` made an empty directory, so every repository looked like a first-time write and `check --write` always had a file to create. It now materialises a wrong file for a repository the generator calls drifting, which is the only state in which the bug exists. `check --write` in the fake wrote unconditionally, making the double more capable than the real generator. `git status --porcelain` called the tree dirty whenever the file existed. With a file present from the clone, existence proves nothing, so it now compares contents. With those three corrected and `check --write` still in place, five tests fail. That was the red; `render` is the green.
Running the dependabot and bot test suites leaves bytecode beside the sources, so every session after the first one opens on a dirty tree and has to decide whether five .pyc files are work. They are not. The directories here were written at 10:45 today by whichever run came first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The reconciler detected drift and then fixed none of it, in every repository, in every account —
and reported a clean-looking uniform status while doing so.
check --writecreates the file, or appends an ecosystem the file is missing. It does notrewrite a file that already covers every ecosystem and is simply wrong, which is exactly what drift
is. So every drifting repository ran the write, reached
changed_paths, found nothing, and cameback
skipped:write-made-no-change.Measured 2026-11-02, dry run across
simtabi:cli-kit-jsskipped:write-made-no-changemesobiaskipped:write-made-no-changewould-opennetsapiens-apiskipped:write-made-no-changewould-openrepo-templatesskipped:write-made-no-changesis-sdkskipped:write-made-no-changewould-openrender --writereplaces everything outside the local block, which is what the reconciler exists todo. Verified by hand that it keeps a
# >>> local (kept by the generator)block verbatim, so theone thing a repository owns is not lost.
Why the suite passed
The defect was in the double, not in the assertions — the fake generator was more capable than the
real one, so the tests exercised a world where the bug cannot exist. Three corrections:
git clonemade an empty directorycheck --writealways had a file to createdependabot.ymlfor a repository the generator calls drifting — the only state in which the bug existscheck --writewrote unconditionallygit status --porcelaincalled the tree dirty whenever the file existedWith those three corrected and
check --writestill in place, five tests fail. That was the red;renderis the green. A new test,test_the_rewrite_uses_render_not_check, pins the call directly,beside the existing
test_write_never_carries_strict.Context
This is the second link in the same chain.
#15fixed the first: the write call carried--strict,which the generator refuses with exit 2, so every repository was
skipped:write-exit-2. Bothfailures looked identical from the summary — a uniform
skipped:for the whole estate, with the runreporting success — which is why neither was noticed. Both were found while investigating why
simtabi/netsapiens-apihas a validdependabot.ymland has never had a Dependabot pull request.Second commit
__pycache__/added to.gitignore. Running either test suite leaves bytecode beside the sources,so every session after the first opens on a dirty tree and has to decide whether five
.pycfilesare work.