Repository navigation
fix(dependabot): the reconciler wrote nothing, and passed - #15
Merged
Merged
Conversation
agent-kit's generator refuses --strict beside --write with exit 2, so every drifting repository was recorded as skipped:write-exit-2 and the run still passed. Write with check --write, and count a failed write as an error so the run fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 2026-11-02 apply run (actions run 41470495170) passed on all 10 orgs and opened no pull requests. The reconciler calls the agent-kit generator as
check <clone> --strict --policy … --write, and the generator now refuses that pairing ("--strict goes withcheck, without --write", exit 2). Every drifting repository was recorded asskipped:write-exit-2, andmain()counted only exceptions as errors, so the run went green.reconcile.pywrites withcheck <clone> --write --policy …;--strictstays on the read-only check.skipped:write-exit-*row now counts as an error, so a broken generator fails the run instead of passing silently.--strictwith--writethe way the real generator does. Two new tests: writes never carry--strict, and a failed write fails the run. Without the fix, 7 tests fail; with it, all 15 pass.Checked against real repositories with a local dry run:
simtabi/documentation,marketplace-studio,scoop-bucketandsitesmith-templatewereskipped:write-exit-2and are nowwould-open.