Free memory by deleting random_phi after use - #28
Open
roi-meir wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces peak memory usage during model fitting by explicitly releasing the temporary random_phi Dirichlet matrix immediately after it is used to initialize Xphi_data on the first training iteration (t == 0 with reinit).
Changes:
- Deletes
random_phiright after computingXphi_datain thet == 0 and reinitinitialization path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| random_phi = np.random.dirichlet( np.ones(nfactors), | ||
| X_batch.data.shape[0]) | ||
| Xphi_data = X_batch.data[:,None] * random_phi | ||
| del random_phi # free memory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
random_phiarray right after it is used to initializeXphi_dataon the first training iteration (t==0andreinit).Closes Free memory after initializing random_phi during first training iteration #27