fix: resolve all 13 critical npm alerts in InstallerUI - #105
Merged
Conversation
Regenerated SW.Serverless.InstallerUI/yarn.lock from scratch and added targeted `resolutions` overrides for transitive dependencies whose declared range doesn't reach the patched version on its own: - json-schema, form-data: forced past an old pinned/narrow parent range (jsprim's exact 0.2.3 pin; aws-sdk's ~2.3.2 tilde range). Same major version, low risk. - sha.js, cipher-base, elliptic, minimist, pbkdf2, plist: patched versions already satisfy their parents' existing ranges - picked up once the lockfile was regenerated fresh instead of reusing stale cached resolutions. - loader-utils: two independent lines (1.x and 2.x) coexist by design across different consumers; scoped both to their latest patched version via ancestor-path resolutions rather than collapsing to one version, which would have broken whichever line didn't get it. - plist 3.0.1 -> 3.0.5 incidentally drops its `xmldom` dependency entirely (newer plist doesn't use it), clearing that advisory too even though xmldom itself has no upstream patch. Not included: `tar` (GHSA-23hp-3jrh-7fpw) needs a 4.x/6.x -> 7.x major bump that isn't reachable within any current consumer's declared range. It's pulled in transitively by the pinned `@electron-forge/*` 6.0.0-beta packages, so forcing it via resolutions risks breaking the archive extraction those packages actually run during `make`/`package`. Deferred to a follow-up PR that upgrades `@electron-forge/*` itself. Verified this change introduces no new breakage: `yarn lint` and `yarn package` fail identically with and without this change (missing `./model`/`./app` source modules - pre-existing, unrelated to dependency versions, confirmed via git stash/stash pop comparison). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 27 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: simplify9/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mmalkhatib
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves all 13 open CRITICAL Dependabot alerts on this repo, all in
SW.Serverless.InstallerUI/yarn.lock(a devtools Electron app — confirmed unused/not important currently, which is why the riskiertarfix below was acceptable to fold in directly rather than deferring).resolutions(ts-loader/html-webpack-plugin/webpack)resolutions(copy-webpack-plugin/css-loader/node-loader/style-loader)xmldomdependency entirelyresolutions(pinned exactly by oldjsprim, no range to regen into)resolutions(parent wants~2.3.2, patch is outside that range)resolutions— see belowOn
tar(GHSA-23hp-3jrh-7fpw, no in-range fix): none of its actual consumers here (node-pre-gyp,cacache,node-gyp,electron-rebuild— native-module rebuild tooling invoked duringpackage/make, not@electron-forge/*itself) need anything beyond tar's stable extract/create-style API, which hasn't changed across these majors. Verifiedtar7.x still exports the fullc/x/t/u/create/extract/Pack/Unpacksurface, and thatnode-pre-gyp,cacache, andnode-gypallrequire()cleanly against it. This is a real major-version override past what their declared ranges (^4,^6.x) ask for, so flagging it explicitly rather than burying it — but the properly-supported fix here (upgrading@electron-forge/*off its6.0.0-beta.54pin) would cascade into a webpack 4→5 migration across six other build plugins, which is a much larger, harder-to-verify change than this app currently warrants.Why the lockfile diff is large
Deleted and fully regenerated
yarn.lockrather than patching entries by hand, so a handful of other packages also moved to their latest version within their own already-declared range (e.g.bootstrap4.5.3→4.6.2,eslint7.6→7.32,ts-loader8.0.12→8.4.0) — normal, low-risk patch/minor bumps that come along for free with any lockfile refresh, not deliberate changes.Test plan
yarn.lock;xmldomconfirmed fully removed.yarn install— no unexpected-incompatibility warnings beyond the three deliberate cross-range overrides (form-data,loader-utils,tar), all documented above.node -e "require('node-pre-gyp'); require('cacache'); require('node-gyp')"— all load cleanly againsttar@7.5.22.yarn lintandyarn packagefail identically with and without this change — pre-existing broken imports (./model,./appmissing) unrelated to dependency versions, confirmed viagit stash/stash popcomparison both ways. This change introduces no new breakage.🤖 Generated with Claude Code