fix(build): pin the .NET 8 image back to port 80 - #130
Merged
Conversation
Regression from the .NET 8 base-image bump (#127). The runtime images changed their default listening port between majors: aspnet:6.0 ASPNETCORE_URLS=http://+:80 -> listens on 80 aspnet:8.0 ASPNETCORE_HTTP_PORTS=8080 -> listens on 8080 The chart hardcodes containerPort 80 and the Service targets the named "http" port, so after the bump the app listened on 8080, the Service had no reachable endpoint, and the gateway answered 503 from envoy. It failed silently: the chart ships probes.enabled=false, so with no readiness probe the pod still reported 1/1 Ready while serving nothing. Deployment, Service, EndpointSlice, HTTPRoute and TLS all looked correct -- only an actual request over the wire showed it. Setting ASPNETCORE_HTTP_PORTS=80 restores the 6.0 behaviour exactly, so the chart, the Service and all six releases keep working with no chart change. It stays overridable per-deployment. Verified A/B against a real PostgreSQL, no port env override, exactly as the cluster runs them: ghcr.io/simplify9/mtm:8.0.2 curl :80 -> connection reset (nothing bound) this build curl :80 -> HTTP 404 (app responding) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VHkpqv6dB6wjALyFe9ocMU
|
Warning Review limit reachedNext included review available in 14 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: simplify9/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a regression from #127, and I introduced it
The .NET runtime images changed their default listening port between majors:
aspnet:6.0ASPNETCORE_URLS=http://+:80aspnet:8.0ASPNETCORE_HTTP_PORTS=8080The chart hardcodes
containerPort: 80and the Service targets the namedhttpport. So after the base-image bump the app listened on 8080, the Service had no reachable endpoint, and the gateway returned 503 from envoy.Why it wasn't caught
It fails silently. The chart ships
probes.enabled: false, so with no readiness probe the pod still reports1/1 Readywhile serving nothing. Every layer looked healthy:Only an actual request over the wire revealed it —
curl https://mtm.sf9.io/api→503,server: envoy.Fix
ENV ASPNETCORE_HTTP_PORTS=80in the base stage. This restores the6.0behaviour exactly, so the chart, the Service and all six releases keep working with no chart change, and it remains overridable per-deployment.The alternative — moving the chart's
containerPortto 8080 — would break every deployment still running the6.0.8image, which listens on 80.Verification
A/B against a real PostgreSQL, no port env override, exactly as the cluster runs them:
curlcontainer:80ghcr.io/simplify9/mtm:8.0.2(deployed now)Follow-up worth considering (not in this PR)
probes.enabled: falseis why a completely unreachable pod reported Ready. Turning on a readiness probe would have caught this at deploy time and rolled the release back automatically, since the deploys run with--atomic.🤖 Generated with Claude Code
https://claude.ai/code/session_01VHkpqv6dB6wjALyFe9ocMU