Drop warning and ruby 1.9 support.#1172
Merged
sferik merged 3 commits intosimplecov-ruby:mainfrom Apr 23, 2026
Merged
Conversation
sferik
requested changes
Apr 17, 2026
Collaborator
There was a problem hiding this comment.
I would approve this after a few small changes:
- I’m not sure why you added
spec/fixtures/issue_1057.erb, but it doesn’t seem to be referenced anywhere, so please either use it or remove it. - The
capture_stderris now unused and can be removed. - Add a positive regression test:
expect { subject.lines }.not_to output.to_stderrso silence is pinned.
Collaborator
|
@coorasse Are you planning to make these changes so this PR can be merged or would you like me to take it over? |
Contributor
Author
|
On it right now 👍 thanks |
Contributor
Author
|
Adapted. Sorry for the |
sferik
approved these changes
Apr 23, 2026
Collaborator
|
Merged! Thanks so much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From my understanding the warning was introduced in the issue #56 and it's interesting only for ruby 1.9, which is not supported anymore anyway.
So let's get rid of this warning completely and close #1057 as well.