feat(vocab): FTS5 synonym expansion + XKCD colour-survey palette - #24
Merged
Conversation
synonyms.py: freshly-authored synonym groups (rooms, heating, media, power, UK household terms). Words found in a device's name/model/ folder pull their group siblings into the aliases FTS column, so 'lounge' finds Living Room devices and 'telly' finds the TV socket — the synonym-recall benefit of semantic search with zero deps. xkcd_palette.py: ~920 colour names from the CC0 xkcd colour survey as a plain data table (no matplotlib). lookup_named_color falls back to it after CSS (CSS wins collisions); US/UK grey spellings resolve both ways. 'british racing green' is now a real colour, so the unknown-colour test fixtures move to a genuinely fake name. Closes #18, closes #19. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EYAGXd4bE9D9Z5kZeSHeo7
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- SQLite opens read-only via URI (mode=ro): a typo'd path now fails loudly instead of silently creating an empty DB and logging ready. - get_columns propagates connection failures instead of returning [] so a Postgres outage is no longer misreported as 'device has no history'; list_sql_logger_columns wraps them as friendly errors. - HistoryDB.from_prefs replaces plugin-side wiring: malformed prefs (non-numeric pgPort) disable history tools with an error instead of crashing startup/prefs-save; fully unit-tested. - psql short-row guard: --unaligned trims trailing NULL fields; raw/ bucketed loops now skip short tuples (caught by new PG stdout test). - Text values in numeric series are skipped, not fatal. - Colour lookup normalises apostrophes/slashes (robin's egg blue, purple/blue) and the XKCD table regains 2 apostrophe-named entries; xkcd import hoisted to module level so corruption fails at load. - 302 tests (8 new review-driven). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EYAGXd4bE9D9Z5kZeSHeo7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18, closes #19. Stacked on #23 (which stacks on #22) — merge in order, retarget before deleting base branches.
aliasesFTS column (bm25 weight 2.0, below name's 3.0). This captures the synonym-recall benefit that was embedding search's only real advantage — zero deps, zero network, zero per-query cost.(r,g,b)dict (no matplotlib).lookup_named_colorchecks CSS first (collisions keep CSS values), then XKCD, with grey/gray spelling handled both directions.🤖 Generated with Claude Code
https://claude.ai/code/session_01EYAGXd4bE9D9Z5kZeSHeo7