Forge hardening: RPC parity, phased model evolution, and execution safeguards

[simonperegrinvs]

Summary

This PR executes the Forge hardening plan in task-scoped commits (tests first, one commit per task).

Note: risk-adaptive-loop was removed from this branch per reviewer feedback and is no longer included.

Task 1: Daemon RPC parity

• Routed all forge_* methods through daemon JSON-RPC workspace dispatcher (src-tauri/src/bin/codex_monitor_daemon/rpc/workspace.rs).
• Added RPC tests proving remote routing for forge_list_bundled_templates and forge_list_plans (src-tauri/src/bin/codex_monitor_daemon.rs).

Task 2: AI review gate enforcement

• Added machine-enforced AI-review evidence check in src-tauri/src/shared/forge_execute_core.rs.
• ai-review now requires plans/<plan_id>/ai-review/<task_id>.json with schema forge-ai-review-v1, matching taskId, and findings: [].
• Added/updated core tests for missing report, non-zero findings, and success path.
• Updated test-first-loop phase/prompt contract to document the artifact.

Task 3: Forge polling hardening

• Hardened plan polling to avoid stale in-flight updates crossing workspace boundaries (src/features/forge/components/Forge.tsx).
• Added request/workspace guards and centralized polling intervals.
• Added component test for stale-response workspace-switch scenario (src/features/forge/components/Forge.plans.test.tsx).

Task 4: Execution loop safeguards

• Added configurable execution limits in useForgeExecution (src/features/forge/hooks/useForgeExecution.ts):
  • phase status poll interval
  • phase status timeout
  • max phase-check failures
• Added hook tests for timeout and retry-budget exhaustion (src/features/forge/hooks/useForgeExecution.test.ts).

Task 5: Code quality fixes

• Updated skill sync to refresh stale files in .agents/skills when source content changes (src-tauri/src/shared/forge_templates_core.rs).
• Aligned Forge phase icon fallback to a valid default (file) (src/services/tauri.ts).
• Added coverage for fallback icon metadata parsing (src/services/tauri.test.ts).

Validation

• npm run typecheck
• npm run test
• cd src-tauri && cargo check
• cd src-tauri && cargo test forge_execute_core --lib
• cd src-tauri && cargo test forge_templates_core --lib
• cd src-tauri && cargo test rpc_forge_list_ --bin codex_monitor_daemon

Plan Artifact

• Added tracked execution plan: docs/forge-hardening-execution-plan.json