Draft
Conversation
This reverts commit d755b1c.
There was a problem hiding this comment.
Pull request overview
This PR removes a temporary workaround that forced Tide to reload after theme changes. The workaround was necessary because Tide cached colors in _tide_pwd.fish and fish_prompt.fish, preventing dynamic color updates when switching between light and dark themes in Fish 4.3+.
Changes:
- Removed the
tide reloadcommand from the__so_apply_themefunction
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
tide reloadworkaround once Tide handles dynamic color changes properly.Context
This workaround was added to refresh cached colors in Tide's
_tide_pwd.fishandfish_prompt.fish. Once Tide is updated to read colors dynamically at runtime (for Fish 4.3+ auto light/dark theme support), this workaround can be removed.Blocked by #35
🤖 Generated with Claude Code