Repository navigation
Link hovers to real documentation pages (0.3.2) - #7
Merged
Merged
Conversation
Hovers linked to <baseUrl>/<registry ID>, for example /smart.buttons, a page the site never had. Build links from the pages the site lists instead, record those pages in contracts/docs-pages.json, default sf.docs.baseUrl to https://ui.simai.io, and fail the release and the weekly check if a recorded page disappears. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reader reported that the hover link leads to a missing page:
https://ui.simai.io/smart.buttons. Links were built as<baseUrl>/<registry ID>, and the site has no such pages.contracts/docs-pages.json, the reference pages recorded from the site's sitemap (npm run vendor:docs).sf-buttonlinks to/ru/smart-components/actions/buttons/.sf.docs.baseUrldefaults tohttps://ui.simai.io; an empty value means no link./ru/utilities/.npm run docs:checkfails the release and the weekly workflow if a recorded page is no longer published.Verified: 52 of 52 tags have a page, and each page names its tag; all 95 link targets answer 200; unit tests 32/32.
Known limit: the reference exists only in Russian on the site for now, so the links open Russian pages.
🤖 Generated with Claude Code