Repository navigation
Add a checklist for releasing CloudEx allocations - #402
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs sima-neat/kerrigan#118.
Running
sima-cli -i cloudex releasein a terminal opens a checklist styled likedisconnect. Users choose one or more of their allocations by device name, short allocation ID, and state. Pressing Enter with an empty selection does nothing. Passing a full allocation ID still works for scripts.If an allocation has a running local tunnel, the CLI prompts for sudo before starting the progress spinner, then disconnects the tunnel before requesting lease release. If the local tunnel is still running after cleanup fails, the allocation is kept and the CLI continues with the other choices.
Validation: 188 focused CloudEx tests passed on the PR branch and the wheel built successfully. Terminal testing covered multiple selections and empty selection. An installed-build smoke test with mocked operations confirmed the sudo, disconnect, and release order.