partially fix the grid isue for mosaic mask - #1235
Merged
Merged
Conversation
woutdenolf
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On mosaic mask (acquired by workflow on ID21) the order of the motor positioners is weird. Silx fails to find the grid.
It breaks "irregular grid" in ScatterView. And it breaks "Add image" to RGBCorrelator.
small problem: (2) could not be implemented easily to show "irregular grid" in the viewer itself, but since user can still see via "solid" and RGBCorrelator works - it cover the required functionality.