Require zarr>=3 so environments can open v2 API exports - #189
Open
amarcozzi wants to merge 1 commit into
Open
Conversation
The SDK never imports zarr; the dependency exists so that a user's environment can open the zipped-Zarr grid exports the API hands out via signed download URLs. Those exports are Zarr format v3, and zarr-python 2.x cannot read v3 at all, so an unpinned `zarr` that resolves to 2.x leaves the user unable to open an export the SDK just downloaded for them. This mainly affects v1 migrants: v1 pinned zarr==2.18.2 and handed out format v2, so an environment carried over from v1 can be on a zarr that silently cannot read v2 exports. Refs silvxlabs/FastFuels-API-v2#447
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client-side half of silvxlabs/FastFuels-API-v2#447. Paired with the API change that pins the zarr export to format v3 explicitly.
The SDK never imports zarr — the dependency exists so that a user's environment can open the zipped-Zarr grid exports the API hands out via signed download URLs. Those exports are Zarr format v3, and zarr-python 2.x cannot read v3 at all, so an unpinned
zarrthat resolves to 2.x leaves the user unable to open an export the SDK just downloaded for them.This mainly affects v1 migrants:
An environment carried over from v1 can be sitting on a zarr that silently cannot read v2 exports.
zarr>=3makes installing the SDK sufficient to open what it downloads.Changes
"zarr"->"zarr>=3"inpyproject.toml, with a comment explaining that the dep is not imported and exists to provision the user's environment.Release
Version is dynamic via
hatch-vcs, so there's no version field to bump — this needs a tag/publish to reach users.