543 add current year lfps support to api for landfire fuel models - #552
Merged
lindsaywiard merged 7 commits intoAug 28, 2026
Merged
Conversation
…into 543-add-current-year-lfps-support-to-api-for-landfire-fuel-models # Conflicts: # services/griddle/tests/integration/test_landfire_lfps.py
…into 543-add-current-year-lfps-support-to-api-for-landfire-fuel-models
…uel model API routers
amarcozzi
reviewed
Aug 28, 2026
amarcozzi
approved these changes
Aug 28, 2026
Contributor
|
Looks good thank you! I left a comment about expanding the example descriptions but I'll leave it up to you if you want to address those or go ahead and merge. |
lindsaywiard
deleted the
543-add-current-year-lfps-support-to-api-for-landfire-fuel-models
branch
August 28, 2026 18:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API now accepts the latest year's release for FCCS, FBFM13, and FBFM40 through
version, gated by a live LFPS coverage check before the grid is created.Changes
services/api/api/resources/grids/{fbfm13,fccs,fbfm40}/schema.pylfps_availableyearfbfm40'scheck_version_matches_seasonvalidator is simplifiedversionfield's description to name the current LFPS-sourced yearservices/api/api/resources/grids/{fbfm13,fccs,fbfm40}/router.pyvalidate_lfps_coveragebefore creating the grid whenever the requested version islfps_availablefbfm40's existing season-only gate is widened to also cover the no-season "latest release" caseservices/api/api/resources/grids/{fbfm13,fccs,fbfm40}/examples.pylatest_releasedocumented example for each product.STAGED_*_EXAMPLE_VALUES(staged data, tested against any domain) andLFPS_*_EXAMPLE_VALUES(LFPS-sourced, tested against a domain with known coverage).services/api/tests/resources/grids/{fbfm13,fccs,fbfm40}/test_schema.pylfps_availableversion is accepted.fbfm40: removetest that asserted anlfps_availableversion with noseasonwas rejectedservices/api/tests/resources/grids/{fbfm13,fccs,fbfm40}/test_router.pyTestLfpsCoverageclass with a real, live-coverage test of thelatest_releaseexample againstlfps_covered_domain— confirmsvalidate_lfps_coverageactually succeeds against LFPS