Improve testing for FBFM40's seasonal LFPS integration. - #550
Merged
lindsaywiard merged 2 commits intoAug 27, 2026
Merged
Conversation
amarcozzi
approved these changes
Aug 26, 2026
lindsaywiard
deleted the
544-add-live-coverage-testing-for-fbfm40-seasonal-fuels
branch
August 27, 2026 16:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While implementing latest-year LFPS support for LANDFIRE fuel models, I was thinking about confirming the API's coverage check (
validate_lfps_coverage) actually reaches LFPS successfully for an API request that requires LFPS. Working on that, I realized the seasonal FBFM40 was missing this. Its LFPS coverage check is a live call to LFPS's product catalog, made synchronously by the API itself before a grid is created, the same way 3DEP's coverage check works. 3DEP tests live against a domain with known coverage (test_documented_examples_are_acceptedintest_3dep.py), so I thought seasonal should be tested the same way.During the latest-year fuel model implementation in Griddle, I also noticed we had no way to know if our configured seasonal version stops being served by LFPS. We will need to update the code base when LANDFIRE move to a new base vintage, so this test can act as a reminder to check.
Changes
services/api/tests/fixtures.pyshared_dataservices/api/tests/conftest.pylfps_covered_domain, loadingthreedep_ept_seam.jsonvia that factoryservices/api/api/resources/grids/fbfm40/examples.pySPtoESbecause ES is updated firstservices/api/tests/resources/grids/fbfm40/test_router.py:lfps_covered_domainservices/griddle/tests/integration/test_landfire_lfps.py