Remove unused legacy gh-pages deploy path - #10
Merged
Conversation
Now that deployment is handled by the ci-cd.yml workflow via actions/deploy-pages, the predeploy/deploy npm scripts and the gh-pages devDependency (which pushed dist/ to the gh-pages branch) are dead code - the Pages source is now GitHub Actions, so that branch is no longer read by anything.
sillyash
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #9. Now that GitHub Pages source is "GitHub Actions" and deployment is handled by
.github/workflows/ci-cd.yml(actions/deploy-pages), the old manual deploy path is dead:predeploy/deploynpm scripts (they pusheddist/to thegh-pagesbranch, which nothing reads anymore).gh-pagesdevDependency.The
gh-pagesbranch itself will be deleted separately once this merges.Test plan
npm run lintpassesnpm run buildpassesnpm audit --audit-level=criticalpasses