-
-
Notifications
You must be signed in to change notification settings - Fork 5
SF-3692 Reject training data in excel files with missing translations #3639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RaymondLuong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RaymondLuong3 made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion.
src/SIL.XForge.Scripture/Services/TrainingDataService.cs line 69 at r1 (raw file):
continue; } if (row.LastCellNum - row.FirstCellNum < NumTrainingDataColumns)
It seemed like this would not accurately detect that a column was empty. The spreadsheets on the issue show empty cells but this does not appear to consistently detect the empty cells (there might be a logical reason but I did not discover it). So instead of relying on this way of detecting empty cells I have chosen to check the value of each cell instead.
Code quote:
if (row.LastCellNum - row.FirstCellNum < NumTrainingDataColumns)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3639 +/- ##
=======================================
Coverage 83.52% 83.52%
=======================================
Files 610 610
Lines 37509 37512 +3
Branches 6171 6172 +1
=======================================
+ Hits 31329 31332 +3
- Misses 5226 5239 +13
+ Partials 954 941 -13 ☔ View full report in Codecov by Sentry. |
pmachapman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmachapman reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RaymondLuong3).
3b6c5f6 to
6a930cb
Compare
6a930cb to
883ac78
Compare
Excel files were being accepted even though there were missing translations on rows especially if the missing translation was in the first column. This PR explicitly checks the first two columns of the spreadsheet to ensure that the data is present on every row, skipping empty rows.
This change is