Skip to content

LT-22353: Change Hermit Crab to allow merge and split rules #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtmaxwell3 merged 7 commits into from
Jan 20, 2026
Merged

LT-22353: Change Hermit Crab to allow merge and split rules #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
18910f2
LT-22353: Fix bug in NarrowAnalysisRewriteRuleSpec
jtmaxwell3 Jan 15, 2026
12d018a
Fix formatting
jtmaxwell3 Jan 15, 2026
1cb246b
Fix formatting
jtmaxwell3 Jan 15, 2026
fd61903
Add code for expanding rules
jtmaxwell3 Jan 19, 2026
87ac92d
Fix formatting
jtmaxwell3 Jan 19, 2026
0f45197
Remove unused variables
jtmaxwell3 Jan 20, 2026
35e728c
Merge branch 'master' into LT-22353
jtmaxwell3 Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/SIL.Machine.Morphology.HermitCrab/PhonologicalRules/AnalysisRewriteRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,13 @@ Constraint<Word, ShapeNode> constraint in sr.Rhs.Children.Cast<
if (_rule.ApplicationMode == RewriteApplicationMode.Simultaneous)
reapplyType = ReapplyType.SelfOpaquing;
}
else
{
// NarrowAnalysisRewriteRuleSpec works for expansion, too.
ruleSpec = new NarrowAnalysisRewriteRuleSpec(settings, _rule.Lhs, sr);
mode = RewriteApplicationMode.Simultaneous;
reapplyType = ReapplyType.Deletion;
}
Debug.Assert(ruleSpec != null);

PhonologicalPatternRule patternRule = null;
Expand Down
1 change: 1 addition & 0 deletions src/SIL.Machine.Morphology.HermitCrab/PhonologicalRules/NarrowAnalysisRewriteRuleSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ Constraint<Word, ShapeNode> constraint in _analysisRhs.Children.Cast<Constraint<
curNode = targetMatch.Input.Shape.AddAfter(curNode, fs, true);
}

curNode = range.Start;
for (int i = 0; i < _targetCount; i++)
{
curNode.Annotation.Optional = true;
Expand Down
13 changes: 13 additions & 0 deletions src/SIL.Machine.Morphology.HermitCrab/PhonologicalRules/SynthesisRewriteRuleSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,19 @@ IEnumerable<RewriteSubrule> subrules
new EpenthesisSynthesisRewriteSubruleSpec(matcherSettings, isIterative, subrule, i)
);
}
else
{
// NarrowSynthesisRewriteSubruleSpec works for expansion, too.
SubruleSpecs.Add(
new NarrowSynthesisRewriteSubruleSpec(
matcherSettings,
isIterative,
lhs.Children.Count,
subrule,
i
)
);
}
i++;
}
}
Expand Down
164 changes: 164 additions & 0 deletions tests/SIL.Machine.Morphology.HermitCrab.Tests/PhonologicalRules/RewriteRuleTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,170 @@ public void MultipleSegmentRules()
AssertMorphsEqual(morpher.ParseWord("buuubuuu"), "27");
}

[Test]
public void MultipleDeletionRules()
{
var highVowel = FeatureStruct
.New(Language.PhonologicalFeatureSystem)
.Symbol(HCFeatureSystem.Segment)
.Symbol("cons-")
.Symbol("voc+")
.Symbol("high+")
.Value;
var backRndVowel = FeatureStruct
.New(Language.PhonologicalFeatureSystem)
.Symbol(HCFeatureSystem.Segment)
.Symbol("cons-")
.Symbol("voc+")
.Symbol("back+")
.Symbol("round+")
.Value;

var rule1 = new RewriteRule
{
Name = "rule1",
Lhs = Pattern<Word, ShapeNode>.New().Annotation(highVowel).Annotation(highVowel).Value
};
Allophonic.PhonologicalRules.Add(rule1);
rule1.Subrules.Add(
new RewriteSubrule { LeftEnvironment = Pattern<Word, ShapeNode>.New().Annotation(backRndVowel).Value }
);

var morpher = new Morpher(TraceManager, Language);
AssertMorphsEqual(morpher.ParseWord("bubu"), "27", "19");
}

[Test]
public void MergeRules()
{
var highVowel = FeatureStruct
.New(Language.PhonologicalFeatureSystem)
.Symbol(HCFeatureSystem.Segment)
.Symbol("cons-")
.Symbol("voc+")
.Symbol("high+")
.Value;
var backRndVowel = FeatureStruct
.New(Language.PhonologicalFeatureSystem)
.Symbol(HCFeatureSystem.Segment)
.Symbol("cons-")
.Symbol("voc+")
.Symbol("back+")
.Symbol("round+")
.Value;
var t = FeatureStruct
.New(Language.PhonologicalFeatureSystem)
.Symbol(HCFeatureSystem.Segment)
.Symbol("cons+")
.Symbol("alveolar")
.Symbol("del_rel-")
.Symbol("asp-")
.Symbol("vd-")
.Symbol("strident-")
.Value;

var rule1 = new RewriteRule
{
Name = "rule1",
Lhs = Pattern<Word, ShapeNode>.New().Annotation(highVowel).Annotation(highVowel).Value
};
Allophonic.PhonologicalRules.Add(rule1);
rule1.Subrules.Add(
new RewriteSubrule
{
Rhs = Pattern<Word, ShapeNode>.New().Annotation(t).Value,
LeftEnvironment = Pattern<Word, ShapeNode>.New().Annotation(backRndVowel).Value
}
);

var morpher = new Morpher(TraceManager, Language);
AssertMorphsEqual(morpher.ParseWord("butbut"), "27");
}

[Test]
public void MultipleMergeRules()
{
var highVowel = FeatureStruct
.New(Language.PhonologicalFeatureSystem)
.Symbol(HCFeatureSystem.Segment)
.Symbol("cons-")
.Symbol("voc+")
.Symbol("high+")
.Value;
var backRndVowel = FeatureStruct
.New(Language.PhonologicalFeatureSystem)
.Symbol(HCFeatureSystem.Segment)
.Symbol("cons-")
.Symbol("voc+")
.Symbol("back+")
.Symbol("round+")
.Value;
var t = FeatureStruct
.New(Language.PhonologicalFeatureSystem)
.Symbol(HCFeatureSystem.Segment)
.Symbol("cons+")
.Symbol("alveolar")
.Symbol("del_rel-")
.Symbol("asp-")
.Symbol("vd-")
.Symbol("strident-")
.Value;

var rule1 = new RewriteRule
{
Name = "rule1",
Lhs = Pattern<Word, ShapeNode>
.New()
.Annotation(backRndVowel)
.Annotation(highVowel)
.Annotation(highVowel)
.Value
};
Allophonic.PhonologicalRules.Add(rule1);
rule1.Subrules.Add(
new RewriteSubrule { Rhs = Pattern<Word, ShapeNode>.New().Annotation(t).Annotation(t).Value }
);

var morpher = new Morpher(TraceManager, Language);
AssertMorphsEqual(morpher.ParseWord("bttbtt"), "27");
}

[Test]
public void ExpandRules()
{
var highVowel = FeatureStruct
.New(Language.PhonologicalFeatureSystem)
.Symbol(HCFeatureSystem.Segment)
.Symbol("cons-")
.Symbol("voc+")
.Symbol("high+")
.Value;
var backRndVowel = FeatureStruct
.New(Language.PhonologicalFeatureSystem)
.Symbol(HCFeatureSystem.Segment)
.Symbol("cons-")
.Symbol("voc+")
.Symbol("back+")
.Symbol("round+")
.Value;

var rule1 = new RewriteRule
{
Name = "rule1",
Lhs = Pattern<Word, ShapeNode>.New().Annotation(backRndVowel).Value,
};
Allophonic.PhonologicalRules.Add(rule1);
rule1.Subrules.Add(
new RewriteSubrule
{
Rhs = Pattern<Word, ShapeNode>.New().Annotation(highVowel).Annotation(highVowel).Value
}
);

var morpher = new Morpher(TraceManager, Language);
AssertMorphsEqual(morpher.ParseWord("biiiibiiii"), "27");
}

[Test]
public void BoundaryRules()
{
Expand Down
Loading