Repository navigation
fix(tsa,rekor): no dead-code warnings without the client feature - #265
Merged
Merged
Conversation
The RFC 3161 request types and nonce generation are only used by the TSA client, and the Rekor v1 entry-response map only by the Rekor client. Since the ASN.1 module became private (#245) and the response map crate-private (#251), offline builds (default features off, as used by sigstore-verify) warned about them. Compile them only with the client feature or in tests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
jku
approved these changes
Sep 30, 2026
Closed
This was referenced Oct 13, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #245 made the TSA ASN.1 module private, and #251 made Rekor's entry-response map crate-private, offline builds (
--no-default-features, the waysigstore-verifyuses these crates) warned about unused items:TimeStampReq,Asn1MessageImprint::newandgenerate_nonceare only used by the TSA clientLogEntryResponseis only used by the Rekor clientThose items (and their imports) now compile only with the
clientfeature or in tests, andLogEntryResponsemoves next to its single user. No behaviour change.Validation
cargo check --no-default-featuresfor tsa, rekor, verify and sign: no warningscargo clippy --workspace --all-targets --all-features -- -D warningscargo test -p sigstore-tsa -p sigstore-rekor --all-features, pluscargo test -p sigstore-tsa --no-default-featuresSigned-off-by: Wolf Vollprecht w.vollprecht@gmail.com
🤖 Generated with Claude Code