Conversation
…uctor Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
wolfv
force-pushed
the
pre1/fallible-verifier
branch
from
September 5, 2026 19:16
59edc0b to
d143e37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #210.
Verifier::new now returns Result and rejects malformed/unsupported keys, certificates, duplicate log IDs and reversed validity windows before artifact I/O. Prepare Rekor/CT keyrings and Fulcio trust anchors once per verifier; retain dynamic validity-window checks. Constructor errors retain their crypto/trust/certificate sources.
Validation: workspace all-feature tests and strict all-target Clippy passed. Constructor regressions cover invalid Rekor keys, Fulcio/TSA certificates, duplicate CT IDs and reversed windows. Existing certificate/TSA/managed-key fixtures cover the prepared paths.