fix(crypto): check SPKI parameters and scheme compatibility - #207
Open
wolfv wants to merge 1 commit into
Open
Conversation
wolfv
force-pushed
the
pre1/algorithm-contracts
branch
from
September 5, 2026 11:17
03f2937 to
f1c125b
Compare
Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
wolfv
force-pushed
the
pre1/algorithm-contracts
branch
from
September 5, 2026 11:22
f1c125b to
79161d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #206; only two crypto source files change.
Use one checked SPKI algorithm resolver for automatic and explicit-scheme verification-key construction. Reject mismatched curves/algorithms, invalid parameters and non-octet-aligned BIT STRINGs; parse bare RSA keys instead of blindly falling back on every SPKI error. Autodetection now handles P-384, RSA and ML-DSA OIDs alongside P-256/Ed25519.
Validation: workspace all-feature tests and strict Clippy passed. Tests cover P-384 signing/verification, RSA SPKI and PKCS#1 parsing, algorithm substitution and invalid parameters.