Conversation
Collaborator
Author
|
Folded this design into #185 while resolving its merge conflicts, so this stacked PR is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds enum-based artifact source inputs so the main sign/verify functions can accept either artifact bytes/digests or wrapped readers:
ArtifactSource/AsyncArtifactSourcereader(...)/async_reader(...)helpers for easy conversion without trait overlap*_readermethods remain as forwarding compatibility wrappersExample:
Testing
git diff --checkcargo check(cargo/rustc unavailable in this environment)