fix(crypto): use explicit-scheme SPKI constructor in signing test - #188
Merged
Merged
Conversation
jku
approved these changes
Aug 17, 2026
Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
wolfv
force-pushed
the
fix/signing-verification-constructor
branch
from
August 17, 2026 12:01
9dd58f6 to
4899ce2
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the main-branch CI regression introduced when #183 landed after the SPKI constructor rename in #178.
The signing test supplies an explicit scheme, so call
from_spki_with_schemeinstead of the auto-detectingfrom_spki.Verified with:
cargo test -p sigstore-cryptocargo clippy -p sigstore-crypto --all-targets --all-features -- -D warningscargo fmt --all -- --check