Skip to content

Fix builder preference retries and HTTP status handling - #9929

Open
jimmygchen wants to merge 15 commits into
sigp:unstablefrom
jimmygchen:codex/fix-builder-preference-submissions
Open

Fix builder preference retries and HTTP status handling#9929
jimmygchen wants to merge 15 commits into
sigp:unstablefrom
jimmygchen:codex/fix-builder-preference-submissions

Conversation

@jimmygchen

@jimmygchen jimmygchen commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

If a beacon node accepts some builder preferences and rejects others, the validator client retries the whole batch, including entries already accepted. This PR records the accepted entries and retries only the failed ones when the response identifies them.

It also:

  • Falls back from SSZ to JSON only for HTTP 415 (unsupported media type). Retry decisions use the HTTP status, since the error body's code can mean something else.
  • Drops preferences whose slots have passed while waiting for an earlier request.

#9807 already added the initial expired-slot filter and fork grouping. These retry fixes are still needed on unstable.

Production impact has not been measured.

@ethDreamer
Add Gloas bid selection, block production, and bid gossip processing …
eb37595 
…(Gloas builder API 3/5)

Third PR of the Gloas builder API stack:

- beacon_chain: direct builder bid verification (spawned on the blocking
  executor), gossip-bid refinements, wei-domain bid selection
  (`BidCandidate`/`BidSource`), and Gloas block production that assembles
  local, gossip, and direct-builder candidates
- network: process payload-bid and proposer-preference gossip, including the
  new `PayloadBidError` variants
- client: construct the `Builders` service when the Gloas fork is scheduled
  and wire it into the beacon chain

The HTTP API still serves `GET` produceBlockV4 at this point; the `POST`
conversion and the `Eth-Builder-Url` round-trip land in the next PR.

Change-Id: Ieccaee5db81bf871c19cef1b79fc48283be9dd51
@ethDreamer
Convert produceBlockV4 to POST and round-trip Eth-Builder-Url (Gloas …
99bddcf 
…builder API 4/5)

Fourth PR of the Gloas builder API stack (beacon-APIs sigp#630):

- convert `/eth/v4/validator/blocks/{slot}` to POST with an optional
  `BuilderConfig` body (min_bid, builder_boost_factor, direct builders)
- add `POST /eth/v1/validator/builder_preferences` for forwarding signed
  builder preferences
- set `Eth-Builder-Url` on produceBlockV4 responses when a direct-builder bid
  wins, accept it on `POST /eth/v2/beacon/blocks`, and forward the signed
  block to that builder

The validator client still uses the legacy GET methods at this point; it
migrates in the final PR of this stack.

Change-Id: I0ad30b8f36ad9b588ea1a0398220f92c9597bb95
@ethDreamer
Migrate the validator client to the Gloas builder API (Gloas builder …
44f4424 
…API 5/5)

Final PR of the Gloas builder API stack:

- sign builder request-auth and preferences (REQUEST_AUTH signing domain,
  web3signer message type)
- add the builder configuration store (`builder_definitions.yml`) and book
  documentation
- add the builder-preferences service and switch block production to
  `POST` produceBlockV4 with a `BuilderConfig` body, threading the
  `Eth-Builder-Url` header through block publication
- remove the now-unused legacy `GET` produceBlockV4 client methods

Change-Id: Iaeeaf6205a024e4fb9fd11aae6ac6a75978a8320
@jimmygchen jimmygchen added bug Something isn't working ready-for-review The code is ready for review gloas builder API labels Aug 28, 2026
@mergify

mergify Bot commented Aug 28, 2026

Copy link
Copy Markdown

Some required checks have failed. Could you please take a look @jimmygchen? 🙏

@mergify mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Aug 28, 2026
@jimmygchen
jimmygchen force-pushed the codex/fix-builder-preference-submissions branch from 370b815 to 6b1bcef Compare August 28, 2026 00:58
@mergify mergify Bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 28, 2026
@ethDreamer
ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch from 44f4424 to 17bcbc2 Compare September 1, 2026 17:18
@ethDreamer
ethDreamer requested a review from jxs as a code owner September 1, 2026 17:18
@mergify

mergify Bot commented Sep 1, 2026

Copy link
Copy Markdown

This pull request has merge conflicts. Could you please resolve them @jimmygchen? 🙏

@mergify mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 1, 2026
@ethDreamer
ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch 6 times, most recently from 9abe9a1 to 58fba0d Compare September 8, 2026 17:21
@ethDreamer
Convert produceBlockV4 to POST and round-trip Eth-Builder-Url (Gloas …
a03f186 
…builder API 4/5)

Fourth PR of the Gloas builder API stack (beacon-APIs sigp#630):

- convert `/eth/v4/validator/blocks/{slot}` to POST with an optional
  `BuilderConfig` body (min_bid, builder_boost_factor, direct builders)
- add `POST /eth/v1/validator/builder_preferences` for forwarding signed
  builder preferences
- set `Eth-Builder-Url` on produceBlockV4 responses when a direct-builder bid
  wins, accept it on `POST /eth/v2/beacon/blocks`, and forward the signed
  block to that builder

The validator client still uses the legacy GET methods at this point; it
migrates in the final PR of this stack.

Change-Id: I0ad30b8f36ad9b588ea1a0398220f92c9597bb95
@ethDreamer
Migrate the validator client to the Gloas builder API (Gloas builder …
2a6fc09 
…API 5/5)

Final PR of the Gloas builder API stack:

- sign builder request-auth and preferences (REQUEST_AUTH signing domain,
  web3signer message type)
- add the builder configuration store (`builder_definitions.yml`) and book
  documentation
- add the builder-preferences service and switch block production to
  `POST` produceBlockV4 with a `BuilderConfig` body, threading the
  `Eth-Builder-Url` header through block publication
- remove the now-unused legacy `GET` produceBlockV4 client methods

Change-Id: Iaeeaf6205a024e4fb9fd11aae6ac6a75978a8320
@ethDreamer
ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch from 58fba0d to 2a6fc09 Compare September 8, 2026 22:42
@jimmygchen
jimmygchen marked this pull request as draft September 9, 2026 05:15
jimmygchen and others added 3 commits September 9, 2026 05:38
@jimmygchen
Simplify builder preference submission retries
714ab7b
@ethDreamer
Convert produceBlockV4 to POST and round-trip Eth-Builder-Url (Gloas …
81335ac 
…builder API 4/5)

Fourth PR of the Gloas builder API stack (beacon-APIs sigp#630):

- convert `/eth/v4/validator/blocks/{slot}` to POST with an optional
  `BuilderConfig` body (min_bid, builder_boost_factor, direct builders)
- add `POST /eth/v1/validator/builder_preferences` for forwarding signed
  builder preferences
- set `Eth-Builder-Url` on produceBlockV4 responses when a direct-builder bid
  wins, accept it on `POST /eth/v2/beacon/blocks`, and forward the signed
  block to that builder

The validator client still uses the legacy GET methods at this point; it
migrates in the final PR of this stack.

Change-Id: I0ad30b8f36ad9b588ea1a0398220f92c9597bb95
@ethDreamer
Migrate the validator client to the Gloas builder API (Gloas builder …
a434c7d 
…API 5/5)

Final PR of the Gloas builder API stack:

- sign builder request-auth and preferences (REQUEST_AUTH signing domain,
  web3signer message type)
- add the builder configuration store (`builder_definitions.yml`) and book
  documentation
- add the builder-preferences service and switch block production to
  `POST` produceBlockV4 with a `BuilderConfig` body, threading the
  `Eth-Builder-Url` header through block publication
- remove the now-unused legacy `GET` produceBlockV4 client methods

Change-Id: Iaeeaf6205a024e4fb9fd11aae6ac6a75978a8320
@ethDreamer
ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch from 2a6fc09 to a434c7d Compare September 9, 2026 14:33
@jimmygchen
jimmygchen marked this pull request as ready for review September 11, 2026 04:48
@jimmygchen jimmygchen added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 11, 2026
@ethDreamer
ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch from a434c7d to fb8c9a4 Compare September 17, 2026 19:11
@mergify

mergify Bot commented Sep 17, 2026

Copy link
Copy Markdown

This pull request has merge conflicts. Could you please resolve them @jimmygchen? 🙏

@mergify mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 17, 2026
@ethDreamer
ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch 2 times, most recently from dfe9d87 to b050112 Compare September 17, 2026 22:28
@jimmygchen jimmygchen changed the title Fix stale and incorrectly versioned builder preference submissions Fix builder preference retries and HTTP status handling Sep 18, 2026
@jimmygchen
jimmygchen changed the base branch from stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 to unstable September 18, 2026 01:42
@jimmygchen jimmygchen added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 18, 2026
@jimmygchen jimmygchen closed this Sep 18, 2026
@jimmygchen jimmygchen reopened this Sep 18, 2026
@mergify

mergify Bot commented Sep 18, 2026

Copy link
Copy Markdown

This pull request has merge conflicts. Could you please resolve them @jimmygchen? 🙏

@mergify mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 18, 2026
@mergify mergify Bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethDreamer ethDreamer Awaiting requested review from ethDreamer
@jxs jxs Awaiting requested review from jxs

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bug Something isn't working builder API gloas ready-for-review The code is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jimmygchen @ethDreamer