Add User-Agent header to validator client HTTP requests#8481
Closed
jimmygchen wants to merge 2 commits into
Closed
Add User-Agent header to validator client HTTP requests#8481jimmygchen wants to merge 2 commits into
jimmygchen wants to merge 2 commits into
Conversation
Implements identification of Lighthouse validator client in HTTP requests to beacon nodes using User-Agent header with format 'Lighthouse/v<version>'. This helps distributed validator middleware operators identify what their peers are running. Fixes sigp#7963
Member
Author
|
Ah I've just realise this has already been implemented in #7990 |
3 tasks
Member
Author
|
superceded by #8786 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #7963
Proposed Changes
Adds a
User-AgentHTTP header to validator client requests to beacon nodes. The header format isLighthouse/v<version>-<commit>(e.g.,Lighthouse/v8.0.0-67da032).This helps distributed validator middleware operators identify what their peers are running, similar to how Prysm already implements this.