Reduce public api surface#304
Merged
Merged
Conversation
`NodeAddress` and `NodeContact` are re-exported from `handler` and currently appear in the public API (`Event::SessionsExpired`, `Discv5::talk_req`). These two types would be re-exported directly from the crate root.
`RequestId` appears in `TalkRequest::id()`, so this type specifically would need to be re-exported
jxs
reviewed
May 16, 2026
jxs
left a comment
jxs
left a comment
Member
There was a problem hiding this comment.
thanks for this Akihito,
Overall looks good to me! Left just two comments
CC @klkvr @KolbyML @onbjerg @mattsse @kevaundray @theochap @morph-dev @jmezo @njgheorghita @DaniPopes @Vid201 @carver @mskrzypkows @jsvisa @Nesopie @Padraic-O-Mhuiris @ogenev @pedrohba1 @mahmudsudo @0xcrust @LNSD @arsenron @e3243eric @xiaoxianBoy
last call before this gets merged
ackintosh
force-pushed
the
reduce-public-api-surface
branch
from
c388324 to
0d7dde4
Compare
ackintosh
force-pushed
the
reduce-public-api-surface
branch
from
2389208 to
8d04d7f
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #303
Notes & open questions
Change checklist