Skip to content

fix: restore &mut APIs for PendingEntry#302

Merged
jxs merged 1 commit into
sigp:masterfrom
klkvr:klkvr/restore-apis
Apr 28, 2026
Merged

fix: restore &mut APIs for PendingEntry#302
jxs merged 1 commit into
sigp:masterfrom
klkvr:klkvr/restore-apis

Conversation

@klkvr

@klkvr klkvr commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Description

#301 removed APIs exposing mutable access to value of PendingEntry

Notes & open questions

Change checklist

  • Self-review
  • Documentation updates if relevant
  • Tests if relevant

@klkvr

klkvr commented Apr 28, 2026

Copy link
Copy Markdown
Contributor Author

cc @jxs would appreciate if this could make it into the next release 🙏

@jxs jxs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right sorry!

cc @jxs would appreciate if this could make it into the next release 🙏

yeah, I just want us to clean the API and un pub unrequired methods, this one was in that train as I thought it was not used.

@jxs jxs merged commit 0f95be1 into sigp:master Apr 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants