fix: validate request ID length in Message::decode()#296
Merged
Conversation
Message::decode() was constructing RequestId directly from decoded bytes without validating the length. The discv5 spec limits request IDs to a maximum of 8 bytes, and RequestId::decode() already enforces this, but it was not being called during message decoding. This caused the node to accept and echo back oversized request IDs (e.g. 9 bytes) in PONG responses, which violates the spec. The node should silently drop messages with invalid request IDs. Fixes the hive devp2p PingLargeRequestID conformance test. Signed-off-by: Delweng <delweng@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Message::decode()was constructing RequestId directly from decoded bytes without validating the length. The discv5 spec limits request IDs to a maximum of 8 bytes:This caused the node to accept and echo back oversized request IDs (e.g. 9 bytes) in PONG responses, which violates the spec. The node should silently drop messages with invalid request IDs.
Fixes the hive devp2p PingLargeRequestID conformance test.
Notes & open questions
Change checklist