Repository navigation
merge queue: queuing epbs (a7eff24) and #1082 together - #1089
Closed
mergify[bot] wants to merge 3 commits into
Closed
mergify[bot] wants to merge 3 commits into
mergify[bot] wants to merge 3 commits into
Conversation
…dator partial-sig) Replace the Unsupported stub with a SingleValidator partial-signature collection over the PayloadAttestationData Lighthouse passes in, signed under Domain::PTCAttester. No beacon node fetch, no slashing protection, no QBFT: LH fetches the data at the 75% slot cutoff and abstains on no-block, and payload attestations carry no slashable offense. Collection failures are classified for telemetry before the error is surfaced: no-threshold misses (QueueClosedError via collector eviction) warn and increment anchor_ptc_reconstruction_failures_total with reason=no_signature, an upper bound on PTC observation divergence; local faults count as reason=infra. LH crit-logs the returned error either way, so the metric is the measurement channel. Addresses #1077
Review feedback on #1082: the Infra classification arm was uncovered, and an infra CollectionError variant drifting into the no_signature bucket would silently inflate the SIP-94 divergence upper bound. The new test injects EmptySignature and asserts the infra label increments while no_signature stays at zero delta. The two metric tests now serialize via a shared tokio mutex: the zero-delta read crosses a label the other test writes, so the prior sole-writer-per-label safety argument no longer held.
|
Your PR title doesn't follow the Conventional Commit guidelines. Example of valid titles:
Usage:
Breaking Changes Breaking changes are noted by using an exclamation mark. For example:
Help For more information, follow the guidelines here: https://www.conventionalcommits.org/en/v1.0.0/ |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## epbs #1089 +/- ##
=======================================
Coverage ? 63.95%
=======================================
Files ? 163
Lines ? 28261
Branches ? 0
=======================================
Hits ? 18075
Misses ? 10186
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch epbs (a7eff24) and #1082 are queued together for merge.
This pull request has been created by Mergify to check the mergeability of #1082.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:check-success=test-suite-successRequired conditions to stay in the queue:
#approved-reviews-by >= 1check-success=license/clacheck-success=target-branch-checklabel!=do-not-merge