fix(doc): deploy PR 2538 changes in scope of IX-4255#234
Conversation
✅ Deploy Preview for industrial-experience ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Code Review
This pull request adds a “.env.pullrequest” file with hardcoded values for the branch and pull request number. The reviewer notes that hardcoding these values isn’t scalable and suggests using dynamic environment variables, e.g. from GitHub Actions or Netlify, to make the build process more robust. If this is a temporary solution, the reviewer recommends adding comments to clarify its purpose.
| DOCS_BRANCH='main' | ||
| DOCS_BRANCH_TYPE='pull request' | ||
|
|
||
| DOCS_PR_NUMBER='2538' |
There was a problem hiding this comment.
Hardcoding values like the branch name and pull request number in this file is not a scalable practice and can lead to maintenance issues. These values are typically dynamic and should be sourced from CI/CD environment variables provided by your build system (e.g., GitHub Actions, Netlify). This would make the build process more robust and automated.
For example, instead of hardcoding 'main' and '2538', you could use variables provided by your CI environment.
If this is a temporary, one-off solution for a specific deployment, please consider adding comments to the file to clarify its purpose and eventual removal to prevent future confusion.
No description provided.