Skip to content

fix(doc): deploy PR 2538 changes in scope of IX-4255#234

Draft
alexkaduk wants to merge 6 commits into
mainfrom
feature/IX-4255-jsdoc
Draft

fix(doc): deploy PR 2538 changes in scope of IX-4255#234
alexkaduk wants to merge 6 commits into
mainfrom
feature/IX-4255-jsdoc

Conversation

@alexkaduk
Copy link
Copy Markdown
Collaborator

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 6, 2026

Deploy Preview for industrial-experience ready!

Name Link
🔨 Latest commit fa1854d
🔍 Latest deploy log https://app.netlify.com/projects/industrial-experience/deploys/6a02fbdca199d10008209b05
😎 Deploy Preview https://deploy-preview-234--industrial-experience.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a “.env.pullrequest” file with hardcoded values for the branch and pull request number. The reviewer notes that hardcoding these values isn’t scalable and suggests using dynamic environment variables, e.g. from GitHub Actions or Netlify, to make the build process more robust. If this is a temporary solution, the reviewer recommends adding comments to clarify its purpose.

Comment thread .env.pullrequest Outdated
Comment on lines +1 to +4
DOCS_BRANCH='main'
DOCS_BRANCH_TYPE='pull request'

DOCS_PR_NUMBER='2538'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoding values like the branch name and pull request number in this file is not a scalable practice and can lead to maintenance issues. These values are typically dynamic and should be sourced from CI/CD environment variables provided by your build system (e.g., GitHub Actions, Netlify). This would make the build process more robust and automated.

For example, instead of hardcoding 'main' and '2538', you could use variables provided by your CI environment.

If this is a temporary, one-off solution for a specific deployment, please consider adding comments to the file to clarify its purpose and eventual removal to prevent future confusion.

@alexkaduk alexkaduk changed the base branch from main to development-5.0.0 May 6, 2026 07:25
Base automatically changed from development-5.0.0 to main May 8, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant