Repository navigation
Fix blank gallery after fleet host releases - #50
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fleet publisher copied the deployment index and Worker modules but omitted the content-addressed asset bodies under
deploy-blobs/. After a host release changedgallery.js, login and the HTML shell still loaded from existing assets, while the missing JavaScript body left the gallery blank.Copy staged asset bodies before deployment metadata and before publishing any pointer. Extend the real two-node fleet integration test to fetch the gallery HTML and compare the served JavaScript bytes and content type on both nodes.
Validation: the new gallery check failed against the previous publisher. With the fix, both real celld nodes served the exact gallery HTML/JavaScript; all 48 assertions in the full fleet test completed, but the local run hit its four-minute timeout during cleanup. The native Worker type check and suite passed (8 tests; separately exercised integrations skipped), and the minified host build and publisher bundle build passed. CI will rerun the full fleet integration.