Repository navigation
Keep fleet publisher SHA tags separate from runtime images - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fleet publisher's SHA tag collided with the runtime image.
docker/metadata-actionsetstype=sha's prefix tosha-, which overrides the global flavor prefix, so both matrix targets pushed the samesha-<commit>tag. The fleet job then failed its check for the missingfleet-sha-<commit>tag.Set the prefix explicitly on the SHA rule. Runtime images retain
sha-<commit>; publisher images usefleet-sha-<commit>. This is a one-line workflow fix, verified against metadata-action v5's prefix handling and the failed job's generated tags;git diff --checkpassed.The current c4ffcb9 image pair was successfully built and pushed, and all test/build jobs passed. Deployment PR https://github.com/atm-com/kubernetes-manifests/pull/454 will pin the verified immutable image digests, avoiding the colliding tags.