Skip to content

fix: build should return noop on non-ci environments#291

Open
vigneshshanmugam wants to merge 1 commit into
siddharthkp:masterfrom
vigneshshanmugam:handle-non-ci
Open

fix: build should return noop on non-ci environments#291
vigneshshanmugam wants to merge 1 commit into
siddharthkp:masterfrom
vigneshshanmugam:handle-non-ci

Conversation

@vigneshshanmugam

@vigneshshanmugam vigneshshanmugam commented Mar 26, 2019

Copy link
Copy Markdown

Description

  • On non ci envrionements like running on local machine, bundlesize should not try to update non existing Github build statuses even though the token env is set.

Motivation and Context

  • export BUNDLESIZE_GITHUB_TOKEN="blah"
  • npm run bundlesize
 ERROR  Could not add github status.
      404: Not Found

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant